[Maven] Avoid retrying requests to repos excessively#5130
Merged
Conversation
jakecoffman
approved these changes
May 11, 2022
brrygrdn
force-pushed
the
brrygrdn/reduce-maven-retries
branch
from
6f28672 to
020a9c2
Compare
brrygrdn
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excon has a default retry strategy of
4requests.As part of Maven updates, we attempt to find a list of repository URLs to lookup in "parent" pom files, but generally treat a non-200 response as a nil return. In the case a parent URL points to a host that is unreachable, we can spend up to 100 seconds attempting a single this with the current configuration.
We should tolerate network weather, but 5 attempts is fairly excessive, so let's drop to a single retry for 2 attempts overall.